Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix: remove unused date object#445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

bcpeinhardt
Copy link
Collaborator

This date object doesn't get used for anything, I'm not sure why it's being passed.

Copy link
Member

@ParkreinerParkreiner left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Is this right? I just pulled down the PR branch, and I'm getting feedback from the IDE that we need the date argument.

This is the version of the function I see:

getWorkspaceBuildLogs=async(buildId:string,before:Date,):Promise<TypesGen.ProvisionerJobLog[]>=>{constresponse=awaitthis.axios.get<TypesGen.ProvisionerJobLog[]>(`/api/v2/workspacebuilds/${buildId}/logs?before=${before.getTime()}`,);returnresponse.data;};

@bcpeinhardt
Copy link
CollaboratorAuthor

sigh wtf mine doesn't have a date parameter. Hold on let me figure out if somethings wonky, I'll do a fresh clone.

@bcpeinhardt
Copy link
CollaboratorAuthor

On a completely fresh clone for me there's no Date parameter, something's weird here.

@bcpeinhardt
Copy link
CollaboratorAuthor

Okay so the difference appears to be in howyarn install vsnpm install handles our vendored setup.yarn install leaves the date param there, whereasnpm install removes the date param. In code/coder, the date param is not present.

@bcpeinhardtbcpeinhardt merged commit4a0f23d intomainMar 4, 2025
2 checks passed
@bcpeinhardtbcpeinhardt deleted the bcpeinhardt/fix-old-type-error-hanging-around branchMarch 4, 2025 16:51
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@ParkreinerParkreinerParkreiner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@bcpeinhardt@Parkreiner
[8]ページ先頭
©2009-2025 Movatter.jp