- Notifications
You must be signed in to change notification settings - Fork23
fix: remove unused date object#445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Parkreiner left a comment• edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Is this right? I just pulled down the PR branch, and I'm getting feedback from the IDE that we need the date argument.
This is the version of the function I see:
getWorkspaceBuildLogs=async(buildId:string,before:Date,):Promise<TypesGen.ProvisionerJobLog[]>=>{constresponse=awaitthis.axios.get<TypesGen.ProvisionerJobLog[]>(`/api/v2/workspacebuilds/${buildId}/logs?before=${before.getTime()}`,);returnresponse.data;};
sigh wtf mine doesn't have a date parameter. Hold on let me figure out if somethings wonky, I'll do a fresh clone. |
On a completely fresh clone for me there's no Date parameter, something's weird here. |
Okay so the difference appears to be in how |
4a0f23d intomainUh oh!
There was an error while loading.Please reload this page.
This date object doesn't get used for anything, I'm not sure why it's being passed.