Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

properly escape . in host -> ssh conversion#421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

bcpeinhardt
Copy link
Collaborator

When validating that our settings are not overridden by a user's ssh config, we were converting host names to regular expressions to use as matchers. In doing so, we were not correctly escaping. characters, which are special in regular expressions but not in host names.
This triggered a false flag when using the vscode extension alerting the user they were improperly overriding settings which they were not.
Note: this didn't come up before because we only now started usingcoder. has a host name in the ssh config as part of updating the vscode extension to simply usecoder ssh as opposed to a dedicatedcoder vscodessh command.

@bcpeinhardtbcpeinhardt merged commitb8645db intomainJan 17, 2025
2 checks passed
@bcpeinhardtbcpeinhardt deleted the bcpeinhardt/escape-dots-in-ssh-to-regex-conversion branchJanuary 17, 2025 21:38
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@code-ashercode-ashercode-asher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@bcpeinhardt@code-asher

[8]ページ先頭

©2009-2025 Movatter.jp