Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: add VS code notifications for workspace actions#111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Kira-Pilot merged 17 commits intomainfromworkspace-action-notifications/kira-pilot
Jun 27, 2023

Conversation

@Kira-Pilot
Copy link
Member

@Kira-PilotKira-Pilot commentedJun 21, 2023•
edited
Loading

Opening this PR in place of#110 as this solution is a little cleaner.
Thisresolvescoder/coder#7360
Screenshot 2023-06-22 at 12 33 03 PM

@Kira-PilotKira-Pilot requested review fromcode-asher and removed request forrodrimaiaJune 22, 2023 17:33
Copy link
Member

@code-ashercode-asher left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks great! Love to see the# syntax at work.

I have not tried it out yet since when I build it tells medeleting_at does not exist. Do we need to update thecoder dependency maybe?

@Kira-Pilot
Copy link
MemberAuthor

Kira-Pilot commentedJun 23, 2023•
edited
Loading

I have not tried it out yet since when I build it tells medeleting_at does not exist. Do we need to update thecoder dependency maybe?

Done! Let me know if you still see that error.

Copy link
Member

@code-ashercode-asher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Works like a charm!

Kira-Pilot reacted with hooray emoji
@Kira-PilotKira-Pilot merged commit713b2bd intomainJun 27, 2023
@Kira-PilotKira-Pilot deleted the workspace-action-notifications/kira-pilot branchJune 27, 2023 14:39
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@code-ashercode-ashercode-asher approved these changes

@kylecarbskylecarbsAwaiting requested review from kylecarbs

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

workspace actions: add VS Code notifications for workspace messaging

2 participants

@Kira-Pilot@code-asher
[8]ページ先頭
©2009-2025 Movatter.jp