Commitc1ac29d

committed

Review comments

1 parent116c94f commitc1ac29dCopy full SHA for c1ac29d

File tree

+36

-13

lines changed

+36

-13

lines changed

Lines changed: 0 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -46,9 +46,6 @@ jobs:`
`46`	`46`	`name:Package`
`47`	`47`	`runs-on:ubuntu-22.04`
`48`	`48`	`needs:[lint, test]`
`49`		`-outputs:`
`50`		`-packageName:${{ steps.setup.outputs.packageName }}`
`51`		`-version:${{ steps.version.outputs.version }}`
`52`	`49`	`steps:`
`53`	`50`	`-uses:actions/checkout@v5`
`54`	`51`

Lines changed: 18 additions & 5 deletions

Original file line number	Diff line number	Diff line change
`@@ -23,11 +23,6 @@ jobs:`
`23`	`23`	`with:`
`24`	`24`	`node-version:"22"`
`25`	`25`
`26`		`- -name:Install dependencies`
`27`		`-run:\|`
`28`		`- yarn`
`29`		`- npm install -g @vscode/vsce`
`30`		`-`
`31`	`26`	`-name:Extract version from tag`
`32`	`27`	`id:version`
`33`	`28`	`run:\|`
`@@ -37,6 +32,24 @@ jobs:`
`37`	`32`	`echo "version=$VERSION" >> $GITHUB_OUTPUT`
`38`	`33`	`echo "Pre-release version: $VERSION"`
`39`	`34`
	`35`	`+ -name:Validate version matches package.json`
	`36`	`+run:\|`
	`37`	`+ TAG_VERSION="${{ steps.version.outputs.version }}"`
	`38`	`+ PACKAGE_VERSION=$(node -e "console.log(require('./package.json').version)")`
	`39`	`+`
	`40`	`+ if [ "$TAG_VERSION" != "$PACKAGE_VERSION" ]; then`
	`41`	`+ echo "Error: Tag version ($TAG_VERSION) does not match package.json version ($PACKAGE_VERSION)"`
	`42`	`+ echo "Please ensure the tag version matches the version in package.json"`
	`43`	`+ exit 1`
	`44`	`+ fi`
	`45`	`+`
	`46`	`+ echo "Version validation successful: $TAG_VERSION"`
	`47`	`+`
	`48`	`+ -name:Install dependencies`
	`49`	`+run:\|`
	`50`	`+ yarn`
	`51`	`+ npm install -g @vscode/vsce`
	`52`	`+`
`40`	`53`	`-name:Setup package path`
`41`	`54`	`id:setup`
`42`	`55`	`run:\|`

Lines changed: 18 additions & 5 deletions

Original file line number	Diff line number	Diff line change
`@@ -24,11 +24,6 @@ jobs:`
`24`	`24`	`with:`
`25`	`25`	`node-version:"22"`
`26`	`26`
`27`		`- -name:Install dependencies`
`28`		`-run:\|`
`29`		`- yarn`
`30`		`- npm install -g @vscode/vsce`
`31`		`-`
`32`	`27`	`-name:Extract version from tag`
`33`	`28`	`id:version`
`34`	`29`	`run:\|`
`@@ -37,6 +32,24 @@ jobs:`
`37`	`32`	`echo "version=$VERSION" >> $GITHUB_OUTPUT`
`38`	`33`	`echo "Release version: $VERSION"`
`39`	`34`
	`35`	`+ -name:Validate version matches package.json`
	`36`	`+run:\|`
	`37`	`+ TAG_VERSION="${{ steps.version.outputs.version }}"`
	`38`	`+ PACKAGE_VERSION=$(node -e "console.log(require('./package.json').version)")`
	`39`	`+`
	`40`	`+ if [ "$TAG_VERSION" != "$PACKAGE_VERSION" ]; then`
	`41`	`+ echo "Error: Tag version ($TAG_VERSION) does not match package.json version ($PACKAGE_VERSION)"`
	`42`	`+ echo "Please ensure the tag version matches the version in package.json"`
	`43`	`+ exit 1`
	`44`	`+ fi`
	`45`	`+`
	`46`	`+ echo "Version validation successful: $TAG_VERSION"`
	`47`	`+`
	`48`	`+ -name:Install dependencies`
	`49`	`+run:\|`
	`50`	`+ yarn`
	`51`	`+ npm install -g @vscode/vsce`
	`52`	`+`
`40`	`53`	`-name:Setup package path`
`41`	`54`	`id:setup`
`42`	`55`	`run:\|`

Comments

(0)