Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix: create new template version when tfvars change#98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

ethanndickson
Copy link
Member

@ethanndicksonethanndickson commentedSep 12, 2024•
edited
Loading

Closes#97.

@ethanndicksonGraphite App
Copy link
MemberAuthor

This stack of pull requests is managed by Graphite.Learn more about stacking.

Join@ethanndickson and the rest of your teammates onGraphiteGraphite

@ethanndicksonethanndicksonforce-pushed the09-12-fix_create_new_template_version_when_tfvars_change branch from2a47980 to81449d0CompareSeptember 13, 2024 05:02
Name string `json:"name"`
ID uuid.UUID `json:"id"`
Name string `json:"name"`
TFVars map[string]string
Copy link
MemberAuthor

@ethanndicksonethanndicksonSep 13, 2024•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

My understanding from testing is that adding a new field to a struct is backwards compatible (which is also whyomitempty works) - if we read some private state from an older version of the provider the map will just be nil.

@ethanndicksonethanndickson marked this pull request as ready for reviewSeptember 13, 2024 05:04
@ethanndicksonethanndicksonforce-pushed the09-12-fix_create_new_template_version_when_tfvars_change branch from81449d0 tob704ee6CompareSeptember 13, 2024 12:35
@ethanndicksonethanndickson merged commitbf558f5 intomainSep 16, 2024
14 checks passed
@ethanndicksonethanndickson deleted the 09-12-fix_create_new_template_version_when_tfvars_change branchSeptember 16, 2024 04:31
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@deansheatherdeansheatherdeansheather approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change on tf_vars should also trigger a new template version
2 participants
@ethanndickson@deansheather
[8]ページ先頭
©2009-2025 Movatter.jp