- Notifications
You must be signed in to change notification settings - Fork3
fix: downgrade coder v2.15.0 -> 2.14.2#91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite.Learn more about stacking. Join@ethanndickson and the rest of your teammates on |
0a60290 intomain 14 checks passed
Uh oh!
There was an error while loading.Please reload this page.
My original intention was to downgrade so I could make a release with#90, but if we can patch the coder version this week I might just hold off. |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
I don't totally understand why CI tests passed (as goreleaser did not), but upgrading our codersdk
v2.15.0introducedcoderdtestas a dependency, when we want to avoid all the dependencies it requires, i.e. tailscale & gvisor, and the go mod replace directives for them.codersdkv2.14.2works fine against av2.15.0deployment, so this is safe. Whenv2.15.0gets patched we'll upgrade once again.Related:coder/coder#14633
Treating as hotfix & merging.
EDIT: CI passed as tailscale was only imported as a test dependency of
codersdk, which only breaksgo mod tidy.