- Notifications
You must be signed in to change notification settings - Fork3
fix: correctly patch template acl#90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This stack of pull requests is managed by Graphite.Learn more about stacking. Join@ethanndickson and the rest of your teammates on |
Should we also provide/update the example to demonstrate this (if not done already)? |
No, this PR just gives users the expected behavior that when they omit an ACL item from the list in their Terraform config, it will get deleted. |
aa380e2 intomainUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
The provider currently does not remove users or groups from template ACL when applying a config.
This was unfortunately missed by tests, but caught by our use of the provider to manage our dogfood template.
Merely omitting a ACL item in a
coderdAPI request is not enough to delete it, the role string must be set to an empty string.ACL items will now be deleted from the template when they are removed from the config and applied.