Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix: use postgres for tests instead of dbmem#87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

ethanndickson
Copy link
Member

@ethanndicksonethanndickson commentedSep 6, 2024
edited
Loading

Our provider acceptance tests caught a very minor bug indbmem, causing all CI to fail against the latest Coder image.
Since nobody runs Coder usingdbmem, It'd be better to test that the provider runs against the DB that people actually use.

Running the acceptance tests on my dogfood workspace took ~140 seconds, up from ~80 usingdbmem - but I think it's a fine tradeoff, and also means we don't need to modify our test suite to workaround the bug.

Treating this as a hotfix and merging.

johnstcn reacted with heart emoji
@ethanndicksonGraphite App
Copy link
MemberAuthor

This stack of pull requests is managed by Graphite.Learn more about stacking.

Join@ethanndickson and the rest of your teammates onGraphiteGraphite

@ethanndicksonethanndickson self-assigned thisSep 6, 2024
@ethanndicksonethanndickson marked this pull request as ready for reviewSeptember 6, 2024 04:58
@ethanndicksonethanndickson changed the titlechore: use postgres for tests instead of dbmemfix: use postgres for tests instead of dbmemSep 6, 2024
@ethanndicksonethanndickson merged commit913c3ed intomainSep 6, 2024
14 checks passed
@ethanndicksonethanndickson deleted the 09-06-chore_use_postgres_for_tests_instead_of_dbmem branchSeptember 6, 2024 04:59
@matifali

This comment was marked as off-topic.

@ethanndickson

This comment was marked as off-topic.

@ethanndickson

This comment was marked as off-topic.

@matifali
Copy link
Member

Sorry I got confused withcoder/terraform-provider-coder. All good here 😄

ethanndickson reacted with heart emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees

@ethanndicksonethanndickson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@ethanndickson@matifali

[8]ページ先頭

©2009-2025 Movatter.jp