- Notifications
You must be signed in to change notification settings - Fork3
fix: use postgres for tests instead of dbmem#87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
ethanndickson merged 1 commit intomainfrom09-06-chore_use_postgres_for_tests_instead_of_dbmemSep 6, 2024
Merged
fix: use postgres for tests instead of dbmem#87
ethanndickson merged 1 commit intomainfrom09-06-chore_use_postgres_for_tests_instead_of_dbmemSep 6, 2024
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite.Learn more about stacking. Join@ethanndickson and the rest of your teammates on |
913c3ed intomain 14 checks passed
Uh oh!
There was an error while loading.Please reload this page.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry I got confused with |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Our provider acceptance tests caught a very minor bug in
dbmem, causing all CI to fail against the latest Coder image.Since nobody runs Coder using
dbmem, It'd be better to test that the provider runs against the DB that people actually use.Running the acceptance tests on my dogfood workspace took ~140 seconds, up from ~80 using
dbmem- but I think it's a fine tradeoff, and also means we don't need to modify our test suite to workaround the bug.Treating this as a hotfix and merging.