Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

chore: validate fields as per coderd#85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

ethanndickson
Copy link
Member

@ethanndicksonethanndickson commentedSep 3, 2024
edited
Loading

Unfortunately,coderd validation errors don't return the reason why the validation failed, leading to confusing (almost useless) error messages when creating templates, groups or users with invalid names via the provider.

The changes oncoderd/httpapi to resolve this are non-trivial, as thestruct validation library we use doesn't appear to support attaching an error reason to a field validator function.

Instead, we'll translate the string validation functions and regex fromcoderd/httpapi/name.go.

@ethanndicksonGraphite App
Copy link
MemberAuthor

This stack of pull requests is managed by Graphite.Learn more about stacking.

Join@ethanndickson and the rest of your teammates onGraphiteGraphite

@ethanndicksonethanndickson marked this pull request as ready for reviewSeptember 3, 2024 08:28
@ethanndicksonethanndickson merged commit21bd3ee intomainSep 3, 2024
14 checks passed
@ethanndicksonethanndickson deleted the 09-03-chore_validate_fields_as_per_coderd branchSeptember 3, 2024 08:34
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@deansheatherdeansheatherdeansheather approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@ethanndickson@deansheather

[8]ページ先頭

©2009-2025 Movatter.jp