Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix: fix minimum coder version warning#72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
matifali merged 5 commits intomainfrommatifali/min-version-fix
Aug 16, 2024

Conversation

matifali
Copy link
Member

@matifalimatifali commentedAug 15, 2024
edited
Loading

It was incorrectly linked to 2.13.0.

@matifali
Copy link
MemberAuthor

@ethanndickson I don't know what Linter is unhappy about my PR.

@ethanndickson
Copy link
Member

@matifali Fixed. That was justgolangci-lint, however the CI's using a newer version than is installed on our dogfood template.

matifali reacted with heart emoji

@ethanndickson
Copy link
Member

ethanndickson commentedAug 16, 2024
edited
Loading

The provider does work against Coder deployments going back to 2.10.1, even though those versions aren't technically supported.

Do we have any other projects that operate against a Coder deployment, that can be used against older, unsupported versions, absolutely fine? What Coder version do we say the software requires in those cases?

The IDE extensions download older slim binaries from the deployment, so I don't believe they're relevant.

@matifali
Copy link
MemberAuthor

matifali commentedAug 16, 2024
edited
Loading

Ok I will just change the link to 2.10.1 then for now.
The PR mainly addresses the wrong link. Because clicking 2.10.1 takes you to 2.13.0.
So just change the link for now and we can bump this version if/when we add new features that are only available in newer versions.

ethanndickson reacted with thumbs up emoji

@matifalimatifali merged commit1a38271 intomainAug 16, 2024
@ethanndicksonethanndickson deleted the matifali/min-version-fix branchAugust 19, 2024 15:10
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@ethanndicksonethanndicksonethanndickson approved these changes

@deansheatherdeansheatherAwaiting requested review from deansheather

Assignees

@matifalimatifali

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@matifali@ethanndickson

[8]ページ先頭

©2009-2025 Movatter.jp