- Notifications
You must be signed in to change notification settings - Fork4
chore: update readme, add version warnings, examples#71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
chore: update readme, add version warnings, examples#71
Uh oh!
There was an error while loading.Please reload this page.
Conversation
ethanndickson commentedAug 13, 2024
This stack of pull requests is managed by Graphite.Learn more about stacking. Join@ethanndickson and the rest of your teammates on |
a052493 toe7838deCompare
matifali left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Great work Ethan. a few nits but LGTM.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
| resource"coderd_template""ubuntu-main" { | ||
| name="ubuntu-main" | ||
| description="The main template for developing on Ubuntu." | ||
| versions=[ | ||
| { | ||
| name="stable-${var.TFC_CONFIGURATION_VERSION_GIT_COMMIT_SHA}" | ||
| description="The stable version of the template." | ||
| directory="./stable-template" | ||
| }, | ||
| { | ||
| name="staging-${var.TFC_CONFIGURATION_VERSION_GIT_COMMIT_SHA}" | ||
| description="The staging version of the template." | ||
| directory="./staging-template" | ||
| } | ||
| ] | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
ethanndicksonAug 13, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
We've just been operating on the assumption that the functionality is there, if people want it.
I only include this example as we currently don't have a great way to otherwise communicate that these versions in the list don't represent a single version on the Coder deployment, and rather are a 'branch' of versions. Though maybe that can be reasonably deduced with one item in the list?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I agree that this example is a best demonstration of the full capability of the provider.
Uh oh!
There was an error while loading.Please reload this page.
e7838de to9628064Compare9628064 to080352dCompareethanndickson commentedAug 13, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Merge activity
|

Uh oh!
There was an error while loading.Please reload this page.
Closes#69.