Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

chore: update readme, add version warnings, examples#71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

ethanndickson
Copy link
Member

@ethanndicksonethanndickson commentedAug 13, 2024
edited
Loading

Closes#69.

@ethanndicksonGraphite App
Copy link
MemberAuthor

This stack of pull requests is managed by Graphite.Learn more about stacking.

Join@ethanndickson and the rest of your teammates onGraphiteGraphite

@ethanndicksonethanndickson marked this pull request as ready for reviewAugust 13, 2024 05:38
@ethanndicksonethanndicksonforce-pushed the08-13-chore_update_readme_add_version_warnings_examples branch froma052493 toe7838deCompareAugust 13, 2024 05:42
Copy link
Member

@matifalimatifali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Great work Ethan. a few nits but LGTM.

Comment on lines 23 to 38
resource "coderd_template" "ubuntu-main" {
name = "ubuntu-main"
description = "The main template for developing on Ubuntu."
versions = [
{
name = "stable-${var.TFC_CONFIGURATION_VERSION_GIT_COMMIT_SHA}"
description = "The stable version of the template."
directory = "./stable-template"
},
{
name = "staging-${var.TFC_CONFIGURATION_VERSION_GIT_COMMIT_SHA}"
description = "The staging version of the template."
directory = "./staging-template"
}
]
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I know that we support multiple versions of a template where one can be set as active. But should we actually recommend customers doing it? How is it more preferred than maintaining two different templates for stable and staging?
I would also like@bpmct and@ammario thoughts on this example.

Copy link
MemberAuthor

@ethanndicksonethanndicksonAug 13, 2024
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

We've just been operating on the assumption that the functionality is there, if people want it.
I only include this example as we currently don't have a great way to otherwise communicate that these versions in the list don't represent a single version on the Coder deployment, and rather are a 'branch' of versions. Though maybe that can be reasonably deduced with one item in the list?

matifali reacted with thumbs up emoji
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I agree that this example is a best demonstration of the full capability of the provider.

@ethanndicksonethanndicksonforce-pushed the08-13-chore_update_readme_add_version_warnings_examples branch frome7838de to9628064CompareAugust 13, 2024 06:17
@ethanndicksonethanndicksonforce-pushed the08-13-chore_update_readme_add_version_warnings_examples branch from9628064 to080352dCompareAugust 13, 2024 06:49
@ethanndicksonGraphite App
Copy link
MemberAuthor

ethanndickson commentedAug 13, 2024
edited
Loading

Merge activity

@ethanndicksonethanndickson merged commitd23df4c intomainAug 13, 2024
14 checks passed
@ethanndicksonethanndickson deleted the 08-13-chore_update_readme_add_version_warnings_examples branchAugust 19, 2024 15:10
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@matifalimatifalimatifali approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Version compatibility with Coder releases
2 participants
@ethanndickson@matifali

[8]ページ先頭

©2009-2025 Movatter.jp