Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix: validate resources against available features before creating#62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

ethanndickson
Copy link
Member

@ethanndicksonethanndickson commentedAug 6, 2024•
edited
Loading

Closes#61

We can't actually validate the fields during the plan, as we don't have access to the provider data store (with the*codersdk.Client) during plan modification, or validation.
Instead we do it duringCreate for enterprise-only resources, andCreate andUpdate for templates.

@ethanndicksonGraphite App
Copy link
MemberAuthor

ethanndickson commentedAug 6, 2024•
edited
Loading

@ethanndicksonethanndicksonforce-pushed the08-06-fix_validate_resources_against_available_features_before_creating branch fromaad8947 toa5e6e53CompareAugust 6, 2024 11:31
@ethanndicksonethanndicksonforce-pushed the08-01-fix_template_version_replacement_metadata_updates branch fromef38461 tob02f6a8CompareAugust 6, 2024 13:59
@ethanndicksonethanndicksonforce-pushed the08-06-fix_validate_resources_against_available_features_before_creating branch froma5e6e53 todb62dccCompareAugust 6, 2024 13:59
@ethanndicksonethanndicksonforce-pushed the08-01-fix_template_version_replacement_metadata_updates branch fromb02f6a8 toeaab432CompareAugust 7, 2024 05:54
@ethanndicksonethanndicksonforce-pushed the08-06-fix_validate_resources_against_available_features_before_creating branch fromdb62dcc to04f9b53CompareAugust 7, 2024 05:54
@ethanndicksonethanndicksonforce-pushed the08-01-fix_template_version_replacement_metadata_updates branch fromeaab432 tocd6a681CompareAugust 7, 2024 05:56
@ethanndicksonethanndicksonforce-pushed the08-06-fix_validate_resources_against_available_features_before_creating branch from04f9b53 to41956b0CompareAugust 7, 2024 05:56
@ethanndicksonethanndickson changed the base branch from08-01-fix_template_version_replacement_metadata_updates tographite-base/62August 7, 2024 05:57
@ethanndicksonethanndicksonforce-pushed the08-06-fix_validate_resources_against_available_features_before_creating branch from41956b0 to19a4577CompareAugust 7, 2024 05:57
@ethanndicksonethanndickson changed the base branch fromgraphite-base/62 tomainAugust 7, 2024 05:58
@ethanndicksonethanndickson marked this pull request as ready for reviewAugust 9, 2024 00:53
@ethanndicksonethanndicksonforce-pushed the08-06-fix_validate_resources_against_available_features_before_creating branch from19a4577 to31a1a2bCompareAugust 9, 2024 00:53
@ethanndicksonethanndicksonforce-pushed the08-06-fix_validate_resources_against_available_features_before_creating branch from31a1a2b tod5b4aceCompareAugust 9, 2024 07:08
@ethanndicksonethanndickson merged commitb768a21 intomainAug 9, 2024
14 checks passed
@ethanndicksonethanndickson deleted the 08-06-fix_validate_resources_against_available_features_before_creating branchAugust 19, 2024 15:10
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@deansheatherdeansheatherdeansheather approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Validate enterprise-only fields during plan
2 participants
@ethanndickson@deansheather
[8]ページ先頭
©2009-2025 Movatter.jp