- Notifications
You must be signed in to change notification settings - Fork4
fix: validate resources against available features before creating#62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
ethanndickson merged 1 commit intomainfrom08-06-fix_validate_resources_against_available_features_before_creatingAug 9, 2024
Merged
fix: validate resources against available features before creating#62
ethanndickson merged 1 commit intomainfrom08-06-fix_validate_resources_against_available_features_before_creatingAug 9, 2024
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
1 task
MemberAuthor
ethanndickson commentedAug 6, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
This stack of pull requests is managed by Graphite.Learn more about stacking. Join@ethanndickson and the rest of your teammates on |
aad8947 toa5e6e53Compareef38461 tob02f6a8Comparea5e6e53 todb62dccCompareb02f6a8 toeaab432Comparedb62dcc to04f9b53Compareeaab432 tocd6a681Compare04f9b53 to41956b0Compare41956b0 to19a4577Compare19a4577 to31a1a2bComparedeansheather approved these changesAug 9, 2024
Uh oh!
There was an error while loading.Please reload this page.
31a1a2b tod5b4aceCompareSign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Closes#61
We can't actually validate the fields during the plan, as we don't have access to the provider data store (with the
*codersdk.Client) during plan modification, or validation.Instead we do it during
Createfor enterprise-only resources, andCreateandUpdatefor templates.