Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat: add coderd_workspace_proxy resource#53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

ethanndickson
Copy link
Member

@ethanndicksonethanndickson commentedJul 30, 2024
edited
Loading

Closes#4

@ethanndicksonGraphite App
Copy link
MemberAuthor

This stack of pull requests is managed by Graphite.Learn more about stacking.

Join@ethanndickson and the rest of your teammates onGraphiteGraphite

@ethanndicksonethanndickson marked this pull request as ready for reviewJuly 30, 2024 05:13
ID: data.ID.ValueUUID(),
Name: data.Name.ValueString(),
DisplayName: data.DisplayName.ValueString(),
Icon: data.Icon.ValueString(),
Copy link
MemberAuthor

@ethanndicksonethanndicksonJul 30, 2024
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Unfortunately, we need a way to populate the session token field duringRead for imports, so we do a redundantPatch. One improvement would be to modifycodersdk and make the other fields onPatchWorkspaceProxy optional.

Name: data.Name.ValueString(),
DisplayName: data.DisplayName.ValueString(),
Icon: data.Icon.ValueString(),
RegenerateToken: true,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This makes the old token invalid. There's no way to read the secret from the API except on create intentionally (it's like a password), so I'd rather we just blocked imports.

There still should be some way to regenerate the token on request, though. I'm not sure how to do that idiomatically in TF.

I also don't mind not allowing regeneration for now until we come up with a better solution. Admins can seamlessly add and remove wsproxies live from a deployment and DERP map updates will be pushed out to all tailnet clients within a minute.

ethanndickson reacted with thumbs up emoji
Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Given the token lasts forever, I think we're all good to just not allow regenerations and imports, at least for now.

Name: data.Name.ValueString(),
DisplayName: data.DisplayName.ValueString(),
Icon: data.Icon.ValueString(),
RegenerateToken: true,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Should not regenerate without the user requesting it.

ethanndickson reacted with thumbs up emoji
@ethanndicksonethanndicksonforce-pushed the07-30-feat_add_coderd_workspace_proxy_resource branch from94f4be2 to55c3559CompareAugust 1, 2024 03:01
@ethanndicksonethanndickson merged commit3209c04 intomainAug 1, 2024
13 checks passed
@ethanndicksonethanndickson deleted the 07-30-feat_add_coderd_workspace_proxy_resource branchAugust 7, 2024 06:00
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@deansheatherdeansheatherdeansheather approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add workspace proxy management capability to coderd provider
2 participants
@ethanndickson@deansheather

[8]ページ先頭

©2009-2025 Movatter.jp