feat: add template data source#46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

deansheather merged 2 commits intomainfromdean/template-datasource

Jul 30, 2024

Merged

feat: add template data source#46

deansheather merged 2 commits intomainfromdean/template-datasource

Jul 30, 2024

Conversation

Copy link

Member

deansheather commentedJul 26, 2024

All fields except a few:

Provisioner (not really necessary in production since we only support terraform right now)
AutostopRequirement andAutostartRequirement (we should add them when the template resource adds them)
MaxPortShareLevel
ACL-related stuff (I think we can add these later when customers request them, but I don't see how they'd be useful on a data source currently)

Closes#28

feat: add template data source

b8d8b63

deansheather requested review fromcoadler andethanndickson

July 26, 2024 16:41

ethanndickson approved these changes

Jul 29, 2024

View reviewed changes

internal/provider/template_data_source.go OutdatedShow resolvedHide resolved

internal/provider/template_data_source_test.go

		Name: PtrTo(tpl.Name),
		}
		resource.Test(t, resource.TestCase{
		IsUnitTest: true,

Copy link

Member

ethanndicksonJul 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I'm not sure if this was on purpose, but it's maybe a good idea, we should leaveIsUnitTest: true on all our acceptance tests, and then just block whenTF_ACC isn't set with a skip at the top. They both do the exact same check, but our skip stops the setup from running too.