Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore: add groups to integration test#34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

ethanndickson
Copy link
Member

@ethanndicksonethanndickson commentedJul 17, 2024•
edited
Loading

I've decided these should go in the existinguser-test integration test case since it's best to test the groups with users in them.

@ethanndicksonethanndicksonforce-pushed the07-17-feat_add_coderd_organization_data_source branch fromf95a970 to695f2f4CompareJuly 17, 2024 07:57
@ethanndicksonethanndicksonforce-pushed the07-17-chore_add_groups_to_integration_test branch from250ad4e toe97e71cCompareJuly 17, 2024 07:57
@ethanndicksonethanndicksonforce-pushed the07-17-feat_add_coderd_organization_data_source branch from695f2f4 to7dc20ebCompareJuly 17, 2024 08:12
@ethanndicksonethanndicksonforce-pushed the07-17-chore_add_groups_to_integration_test branch frome97e71c to40c3e02CompareJuly 17, 2024 08:12
@ethanndicksonethanndickson marked this pull request as ready for reviewJuly 17, 2024 08:14

data"coderd_organization""default" {
is_default=true
}
Copy link
MemberAuthor

@ethanndicksonethanndicksonJul 17, 2024•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I'm not totally sure on this from a UX perspective - but we can't usename="default" because the first organisation, whilst it can be retrieved using the namedefault, actually has the namefirst-organization.

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

and I'm 90% sure Terraform is always going to spit the dummy if we just replaced the given name?

@ethanndicksonethanndickson mentioned this pull requestJul 18, 2024
3 tasks
@ethanndicksonethanndicksonforce-pushed the07-17-feat_add_coderd_organization_data_source branch from7dc20eb to24a0fe9CompareJuly 18, 2024 13:26
@ethanndicksonethanndicksonforce-pushed the07-17-chore_add_groups_to_integration_test branch from40c3e02 toc0065c3CompareJuly 18, 2024 13:26
@ethanndicksonethanndicksonforce-pushed the07-17-feat_add_coderd_organization_data_source branch from24a0fe9 to962336fCompareJuly 18, 2024 13:50
@ethanndicksonethanndicksonforce-pushed the07-17-chore_add_groups_to_integration_test branch fromc0065c3 to3e749a6CompareJuly 18, 2024 13:50
@ethanndicksonethanndicksonforce-pushed the07-17-feat_add_coderd_organization_data_source branch from962336f toadb48deCompareJuly 19, 2024 12:40
@ethanndicksonethanndicksonforce-pushed the07-17-chore_add_groups_to_integration_test branch from3e749a6 to39670c5CompareJuly 19, 2024 12:40
@ethanndicksonethanndicksonforce-pushed the07-17-feat_add_coderd_organization_data_source branch fromadb48de toe313323CompareJuly 19, 2024 12:42
@ethanndicksonethanndicksonforce-pushed the07-17-chore_add_groups_to_integration_test branch from39670c5 to2fca026CompareJuly 19, 2024 12:43
@ethanndicksonethanndicksonforce-pushed the07-17-feat_add_coderd_organization_data_source branch frome313323 to63f4357CompareJuly 19, 2024 12:44
@ethanndicksonethanndicksonforce-pushed the07-17-chore_add_groups_to_integration_test branch from2fca026 to8222503CompareJuly 19, 2024 12:44
@ethanndicksonethanndicksonforce-pushed the07-17-feat_add_coderd_organization_data_source branch from63f4357 toae0d572CompareJuly 19, 2024 12:45
@ethanndicksonethanndicksonforce-pushed the07-17-chore_add_groups_to_integration_test branch from8222503 to2632693CompareJuly 19, 2024 12:45
@ethanndicksonethanndicksonforce-pushed the07-17-feat_add_coderd_organization_data_source branch fromae0d572 toaa86273CompareJuly 22, 2024 12:59
@ethanndicksonethanndicksonforce-pushed the07-17-chore_add_groups_to_integration_test branch 2 times, most recently fromcae8c17 to92ecb54CompareJuly 22, 2024 13:02
@ethanndicksonethanndicksonforce-pushed the07-17-chore_add_groups_to_integration_test branch from92ecb54 tob35dec9CompareJuly 22, 2024 13:02
@ethanndicksonethanndickson changed the base branch from07-17-feat_add_coderd_organization_data_source tomainJuly 22, 2024 13:02
@ethanndicksonethanndickson merged commit75f030f intomainJul 23, 2024
@deansheatherdeansheather deleted the 07-17-chore_add_groups_to_integration_test branchJuly 26, 2024 07:14
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@deansheatherdeansheatherdeansheather approved these changes

@coadlercoadlerAwaiting requested review from coadler

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ethanndickson@deansheather
[8]ページ先頭
©2009-2025 Movatter.jp