- Notifications
You must be signed in to change notification settings - Fork4
chore: add groups to integration test#34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
This was referencedJul 17, 2024
MemberAuthor
ethanndickson commentedJul 17, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
This stack of pull requests is managed by Graphite.Learn more about stacking. Join@ethanndickson and the rest of your teammates on |
f95a970 to695f2f4Compare250ad4e toe97e71cCompare695f2f4 to7dc20ebComparee97e71c to40c3e02Compare| data"coderd_organization""default" { | ||
| is_default=true | ||
| } |
MemberAuthor
ethanndicksonJul 17, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I'm not totally sure on this from a UX perspective - but we can't usename="default" because the first organisation, whilst it can be retrieved using the namedefault, actually has the namefirst-organization.
MemberAuthor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
and I'm 90% sure Terraform is always going to spit the dummy if we just replaced the given name?
3 tasks
7dc20eb to24a0fe9Compare40c3e02 toc0065c3Compare24a0fe9 to962336fComparec0065c3 to3e749a6Compare962336f toadb48deCompare3e749a6 to39670c5Compareadb48de toe313323Compare39670c5 to2fca026Comparee313323 to63f4357Compare2fca026 to8222503Compare63f4357 toae0d572Compare8222503 to2632693Compareae0d572 toaa86273Comparecae8c17 to92ecb54Compare92ecb54 tob35dec9Comparedeansheather approved these changesJul 22, 2024
This was referencedJul 25, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
I've decided these should go in the existing
user-testintegration test case since it's best to test the groups with users in them.