Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat: add coderd_group resource#31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ethanndickson merged 1 commit intomainfromethan/group-resource
Jul 19, 2024
Merged

Conversation

ethanndickson
Copy link
Member

@ethanndicksonethanndickson commentedJul 17, 2024
edited
Loading

Plus some acceptance test clean up.

@ethanndicksonethanndickson marked this pull request as ready for reviewJuly 17, 2024 08:13
Copy link
Member

@deansheatherdeansheather left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good but you should also wait for Colin's review

stringplanmodifier.RequiresReplace(),
},
},
"members": schema.SetAttribute{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

For groups (and eventually orgs), we probably should add some settings:

  • some property likeunmanaged_members = true to avoid management of users (aka. only update the org properties not members)
  • some property likeno_remove_members = true to avoid removing missing members

coadler and ethanndickson reacted with thumbs up emoji
Copy link
MemberAuthor

@ethanndicksonethanndicksonJul 18, 2024
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Terraform doesn't allow providers to modify configured values. For a user to setunmanaged_members totrue, they would also need to setmembers tonull or an empty list (we'll go with null). We can reasonably implement this, but I don't think we need the field for it, setting members to null can just make members not be managed.

For the same reason, implementing ano_remove_members would be messy, as it would require us to store some hidden state separate from the configurablemembers keeping track of all members that the resource has seen throughout it's lifetime. Is this worth it?

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@deansheatherdeansheatherAwaiting requested review from deansheather

@coadlercoadlerAwaiting requested review from coadler

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ethanndickson@coadler@deansheather

[8]ページ先頭

©2009-2025 Movatter.jp