- Notifications
You must be signed in to change notification settings - Fork4
feat: add coderd_group resource#31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
ethanndickson commentedJul 17, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
This stack of pull requests is managed by Graphite.Learn more about stacking. Join@ethanndickson and the rest of your teammates on |
0eade27 to31f7669CompareUh oh!
There was an error while loading.Please reload this page.
31f7669 to0d1743dCompare
deansheather left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Looks good but you should also wait for Colin's review
Uh oh!
There was an error while loading.Please reload this page.
| stringplanmodifier.RequiresReplace(), | ||
| }, | ||
| }, | ||
| "members": schema.SetAttribute{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
For groups (and eventually orgs), we probably should add some settings:
- some property like
unmanaged_members = trueto avoid management of users (aka. only update the org properties not members) - some property like
no_remove_members = trueto avoid removing missing members
ethanndicksonJul 18, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Terraform doesn't allow providers to modify configured values. For a user to setunmanaged_members totrue, they would also need to setmembers tonull or an empty list (we'll go with null). We can reasonably implement this, but I don't think we need the field for it, setting members to null can just make members not be managed.
For the same reason, implementing ano_remove_members would be messy, as it would require us to store some hidden state separate from the configurablemembers keeping track of all members that the resource has seen throughout it's lifetime. Is this worth it?
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
0d1743d to773aee7Compare773aee7 tof555328Compare
Uh oh!
There was an error while loading.Please reload this page.
Plus some acceptance test clean up.