Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: adduse_classic_parameter_flow tocoderd_template resource#251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ethanndickson merged 3 commits intomainfromethan/classic-parameter-flow
Aug 19, 2025

Conversation

ethanndickson
Copy link
Member

@ethanndicksonethanndickson commentedAug 18, 2025•
edited
Loading

Closes#240.

By popular demand, this exposes the fallback to classic parameters via the Template resource.

@ethanndicksonGraphite App
Copy link
MemberAuthor

This stack of pull requests is managed byGraphite. Learn more aboutstacking.

Comment on lines -704 to -708
// TODO(ethanndickson): Remove this once the provider requires a Coder
// deployment running `v2.15.0` or later.
ifnewState.MaxPortShareLevel.IsUnknown() {
newState.MaxPortShareLevel=curState.MaxPortShareLevel
}
Copy link
MemberAuthor

@ethanndicksonethanndicksonAug 18, 2025•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Removed this because I realised I could use planmodifierUseStateForUnknown for it.

Comment on lines +605 to +606
// TODO: Remove this update call (and the attribute) once the provider
// requires a Coder version where this flag has been removed.
Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Coder 2.24 does not include the bool onCreateTemplateRequest, only onUpdateTemplateMeta. 2.25 does include it onCreateTemplateRequest, however.

@ethanndicksonethanndickson marked this pull request as ready for reviewAugust 18, 2025 09:24
Copy link
Member

@aslilacaslilac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

one small clerical suggestion, but the code looks great!

@ethanndicksonGraphite App
Copy link
MemberAuthor

ethanndickson commentedAug 19, 2025•
edited
Loading

Merge activity

  • Aug 19, 12:31 AM UTC: A user started a stack merge that includes this pull request viaGraphite.
  • Aug 19, 12:31 AM UTC:@ethanndickson merged this pull request withGraphite.

@ethanndicksonethanndickson merged commitac0a928 intomainAug 19, 2025
14 checks passed
@ethanndicksonethanndickson deleted the ethan/classic-parameter-flow branchAugust 19, 2025 00:31
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@aslilacaslilacaslilac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing support for "Enable dynamic parameters for workspace creation" setting
2 participants
@ethanndickson@aslilac
[8]ページ先頭
©2009-2025 Movatter.jp