Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat: addcoderd_organization_group_sync resource#248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ethanndickson merged 3 commits intomainfromethan/group-sync-resource
Aug 19, 2025

Conversation

ethanndickson
Copy link
Member

@ethanndicksonethanndickson commentedAug 15, 2025
edited
Loading

Fixes#230.

To avoid users running into circular dependency issues with thegroup_sync block, we'll deprecate the block and add a resource solely for configuring organization group sync.

@ethanndicksonGraphite App
Copy link
MemberAuthor

This stack of pull requests is managed byGraphite. Learn more aboutstacking.

Copilot

This comment was marked as resolved.

@ethanndicksonethanndickson self-assigned thisAug 15, 2025
@ethanndicksonethanndickson changed the titlefeat: addcoderd_organization_group_sync_resourcefeat: addcoderd_organization_group_sync resourceAug 15, 2025
@ethanndicksonethanndickson marked this pull request as ready for reviewAugust 15, 2025 06:51
Copy link
Member

@aslilacaslilac left a comment
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

looking at the code again, I'm remembering the main motivation for making this a nested block: you can only have exactly one group sync config per organization. managing it by a resource instead means that you could theoretically specify multiple of them pointing at the same org, which would be a logic error and produce inconsistent behavior. :\

it's unfortunate that having it as a nested block doesn't work.

ethanndickson reacted with confused emoji
@ethanndicksonGraphite App
Copy link
MemberAuthor

ethanndickson commentedAug 19, 2025
edited
Loading

Merge activity

  • Aug 19, 12:31 AM UTC: A user started a stack merge that includes this pull request viaGraphite.
  • Aug 19, 12:31 AM UTC:@ethanndickson merged this pull request withGraphite.

@ethanndicksonethanndickson merged commit399bfa7 intomainAug 19, 2025
14 checks passed
@ethanndicksonethanndickson deleted the ethan/group-sync-resource branchAugust 19, 2025 00:31
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@aslilacaslilacaslilac left review comments

@deansheatherdeansheatherdeansheather approved these changes

Copilot code reviewCopilotCopilot left review comments

Assignees

@ethanndicksonethanndickson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Managing GroupSync and Organizations
3 participants
@ethanndickson@aslilac@deansheather

[8]ページ先頭

©2009-2025 Movatter.jp