coder/terraform-provider-coderdPublic

NotificationsYou must be signed in to change notification settings
Fork4
Star21

chore: add acceptance tests to user data source#23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

ethanndickson merged 10 commits intomainfromethan/user-data-acc

Jul 16, 2024

Merged

chore: add acceptance tests to user data source#23

ethanndickson merged 10 commits intomainfromethan/user-data-acc

Jul 16, 2024

Conversation

Copy link

Member

ethanndickson commentedJul 15, 2024

No description provided.

ethanndickson added2 commits

July 15, 2024 05:51

chore: add acceptance tests to user data source

e6eb012

error test

3485170

ethanndickson requested review fromcoadler anddeansheather

July 15, 2024 06:39

deansheather approved these changes

Jul 15, 2024

View reviewed changes

internal/provider/user_data_source_test.go OutdatedShow resolvedHide resolved

ethanndickson added4 commits

July 15, 2024 06:57

review

bd799f3

fixup

0f716ed

gen + fmt

eece858

add skip

f149934

ethanndickson commented

Jul 15, 2024

View reviewed changes

internal/provider/user_data_source_test.go

		resource.TestCheckResourceAttr("coderd_user.test", "password", "SomeSecurePassword!"),
		resource.TestCheckResourceAttr("coderd_user.test", "suspended", "false"),
		),
		ifos.Getenv("TF_ACC")=="" {

Copy link

MemberAuthor

ethanndicksonJul 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This is whatresource.Test does when it's run, so we should skip the setup if there's nothing to run.

Copy link

MemberAuthor

ethanndicksonJul 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

You can write all these tests a bit nicer as several steps inside aresource.TestCase, but we're not really doing seperate steps, so subtests are fine.