Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

chore: add acceptance tests to user resource#22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

coadler
Copy link
Contributor

No description provided.

@coadlerGraphite App
Copy link
ContributorAuthor

This stack of pull requests is managed by Graphite.Learn more about stacking.

Join@coadler and the rest of your teammates onGraphiteGraphite

@coadlercoadlerforce-pushed thecolin/chore_add_acceptance_tests_to_user_resource branch from150ca52 toc59c745CompareJuly 12, 2024 18:21
@coadlercoadler marked this pull request as ready for reviewJuly 12, 2024 18:23
@coadlercoadler self-assigned thisJul 12, 2024
-"1.5.*"
-"1.6.*"
-"1.7.*"
-"1.8.*"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

As only 1.8 and 1.9 are supported versions and others have gone into end of life and also we can only test for versions that we include in our supported coder releases.

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Unless this causes maintenance issues I'm inclined to leave this as-is until we want to decide on a support window. It looks like our other terraform provider supports back to 1.5

matifali reacted with thumbs up emoji
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Good enough. 👍🏼

@coadlercoadler merged commit144ff73 intomainJul 15, 2024
@coadlercoadler deleted the colin/chore_add_acceptance_tests_to_user_resource branchJuly 15, 2024 04:33
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@matifalimatifalimatifali left review comments

@deansheatherdeansheatherdeansheather approved these changes

Assignees

@coadlercoadler

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@coadler@matifali@deansheather

[8]ページ先頭

©2009-2025 Movatter.jp