Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix: handle user deletion config drift#209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ethanndickson merged 2 commits intomainfromethan/handle-user-deletion-drift
Apr 16, 2025

Conversation

ethanndickson
Copy link
Member

@ethanndicksonethanndickson commentedApr 14, 2025
edited
Loading

Closes#208.

Queryingapi/v2/users/{ID} returns a valid response for deleted users, as deleted users incoderd are merely tombstoned. To handle this, we perform an additional query by username. If the user has been deleted, the username will be available, or belong to a user with a different ID, in which case we can mark the user resource as deleted.

Also has theisNotFound check include the specific response for when a user does not exist:

sdkErr.StatusCode() == http.StatusBadRequest && strings.Contains(sdkErr.Message, "must be an existing uuid or username")

@ethanndicksonGraphite App
Copy link
MemberAuthor

This stack of pull requests is managed byGraphite. Learn more aboutstacking.

@ethanndicksonethanndickson marked this pull request as ready for reviewApril 14, 2025 07:54
@ethanndicksonethanndickson self-assigned thisApr 14, 2025
@ethanndicksonethanndicksonforce-pushed theethan/handle-user-deletion-drift branch fromadc0503 to24990cbCompareApril 15, 2025 02:28
@ethanndicksonGraphite App
Copy link
MemberAuthor

ethanndickson commentedApr 16, 2025
edited
Loading

Merge activity

  • Apr 15, 9:28 PM EDT: A user started a stack merge that includes this pull request viaGraphite.
  • Apr 15, 9:29 PM EDT: A user merged this pull request withGraphite.

@ethanndicksonethanndickson merged commit5503d71 intomainApr 16, 2025
14 checks passed
@ethanndicksonethanndickson deleted the ethan/handle-user-deletion-drift branchApril 16, 2025 01:29
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@deansheatherdeansheatherdeansheather approved these changes

Assignees

@ethanndicksonethanndickson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Resourcecoderd_user: Plan fails when user was deleted outside of terraform
2 participants
@ethanndickson@deansheather

[8]ページ先頭

©2009-2025 Movatter.jp