Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix: use server computed org display name#183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ethanndickson merged 1 commit intomainfromethan/fix-org-display-name
Feb 24, 2025

Conversation

ethanndickson
Copy link
Member

@ethanndicksonethanndickson commentedFeb 21, 2025
edited
Loading

I picked up on this reviewing#182, but it's a mistake I made when reviewing the resource originally 😓

There's a minor inconsistency between display names on orgs and some other resources with display names oncoderd. i.e. for organizations:

if req.DisplayName == "" {req.DisplayName = req.Name}

For some other resources, e.g. users & groups, an empty string display name is retained, and the CLI/Web UI just shows the actual name if the display name is empty. For those, it's okay to have an empty string default in the provider.

@ethanndicksonGraphite App
Copy link
MemberAuthor

This stack of pull requests is managed byGraphite. Learn more aboutstacking.

@ethanndicksonethanndickson marked this pull request as ready for reviewFebruary 21, 2025 02:50
@ethanndicksonethanndickson merged commite5afa40 intomainFeb 24, 2025
14 checks passed
@ethanndicksonethanndickson deleted the ethan/fix-org-display-name branchFebruary 24, 2025 02:28
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@aslilacaslilacaslilac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@ethanndickson@aslilac

[8]ページ先頭

©2009-2025 Movatter.jp