- Notifications
You must be signed in to change notification settings - Fork3
feat: addcoderd_organization_sync_settings
resource#173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
coderd_organization_sync_settings
resourcecoderd_organization_sync_settings
resource
ethanndickson left a comment• edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I only have so much of an understanding of IdP sync settings, but this mostly lgtm!
My only real comments are on how this resource handles getting imported.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
aslilac commentedFeb 20, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
I'm realizing that you don't actuallyhave to implement import, and I think skipping it is better than a janky import that's weird and has potential issues/adds complexity. There can only ever be one of this type of resource (which does break the Terraform model a bit, but is also what our customers want) so importing isn't actually very helpful here. |
5fa9117
intomainUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Part of#150
Technically, this is complete by itself, as you can entirely configure organization sync this way, but this PR does not include the proposed "partial" API that we would still like to implement.
Example: