Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat: addcoderd_organization_sync_settings resource#173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
aslilac merged 14 commits intomainfromlilac/org-sync
Feb 20, 2025

Conversation

aslilac
Copy link
Member

@aslilacaslilac commentedJan 31, 2025
edited
Loading

Part of#150

Technically, this is complete by itself, as you can entirely configure organization sync this way, but this PR does not include the proposed "partial" API that we would still like to implement.

Example:

resource"coderd_organization_sync_settings""test" {field="wibble"assign_default=falsemapping={wobble= ["bf37c14a-cd36-4bf0-8ffb-e70d6ef8c518",]}}

@aslilacaslilac changed the titlewip:coderd_organization_sync_settings resourcefeat: addcoderd_organization_sync_settings resourceFeb 20, 2025
Copy link
Member

@ethanndicksonethanndickson left a comment
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I only have so much of an understanding of IdP sync settings, but this mostly lgtm!
My only real comments are on how this resource handles getting imported.

@aslilac
Copy link
MemberAuthor

aslilac commentedFeb 20, 2025
edited
Loading

I'm realizing that you don't actuallyhave to implement import, and I think skipping it is better than a janky import that's weird and has potential issues/adds complexity.

There can only ever be one of this type of resource (which does break the Terraform model a bit, but is also what our customers want) so importing isn't actually very helpful here.

ethanndickson reacted with thumbs up emoji

@aslilacaslilac merged commit5fa9117 intomainFeb 20, 2025
13 checks passed
@aslilacaslilac deleted the lilac/org-sync branchFebruary 20, 2025 18:17
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@ethanndicksonethanndicksonethanndickson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@aslilac@ethanndickson

[8]ページ先頭

©2009-2025 Movatter.jp