Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: addcoderd_provisioner_key resource#141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
aslilac merged 9 commits intomainfromlilac/provisioner_key
Nov 15, 2024
Merged

Conversation

aslilac
Copy link
Member

@aslilacaslilac commentedNov 15, 2024•
edited
Loading

These are immutable once created, so really onlyCreate andDelete need implementations. Everything gets stored in Terraform state (including the secret, since it cannot be reacquired any other way).

A change in any attribute must trigger a full replace of the resource.

Copy link
Member

@ethanndicksonethanndickson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Resource is missing the markdown documentation, but CI is passing withoutmake gen having been run 🤔 will fix

ethanndickson added a commit that referenced this pull requestNov 15, 2024
Discovered in#141 that CI could pass even when `make gen` could producea new file.
aslilacand others added5 commitsNovember 15, 2024 11:18
Co-authored-by: Ethan <39577870+ethanndickson@users.noreply.github.com>
@aslilacaslilac marked this pull request as ready for reviewNovember 15, 2024 20:57
@aslilacaslilac merged commite90acf0 intomainNov 15, 2024
13 checks passed
@aslilacaslilac deleted the lilac/provisioner_key branchNovember 15, 2024 21:45
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@ethanndicksonethanndicksonethanndickson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@aslilac@ethanndickson
[8]ページ先頭
©2009-2025 Movatter.jp