Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore: replacePtrTo withptr.Ref#132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
aslilac merged 1 commit intomainfromlilac/ptr-ref
Nov 7, 2024
Merged

chore: replacePtrTo withptr.Ref#132

aslilac merged 1 commit intomainfromlilac/ptr-ref
Nov 7, 2024

Conversation

@aslilac
Copy link
Member

we already import coder/coder into this repo, and it's nice to have one name for things across code bases

Copy link
Member

@ethanndicksonethanndickson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Not totally sure why we addedPtrTo instead of importingptr.Ref in the first place - I think maybe we were afraid of bringing in heavy imports cause it's incoderd?util/ptr doesn't import anything else so it's evidently fine 🤷

@aslilacaslilac merged commit4b8a4b1 intomainNov 7, 2024
13 checks passed
@aslilacaslilac deleted the lilac/ptr-ref branchNovember 7, 2024 18:03
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@ethanndicksonethanndicksonethanndickson approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@aslilac@ethanndickson
[8]ページ先頭
©2009-2025 Movatter.jp