Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: add organization resource#131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
aslilac merged 19 commits intomainfromlilac/add-organization-resource
Nov 14, 2024
Merged

Conversation

aslilac
Copy link
Member

No description provided.

@ethanndickson
Copy link
Member

ethanndickson commentedNov 6, 2024•
edited
Loading

I've got a bunch of boilerplate up on#49, feel free to steal and I'll close that PR. The test boilerplate and the member crud are probably the most useful

@aslilac
Copy link
MemberAuthor

I've got a bunch of boilerplate up on#49, feel free to steal and I'll close that PR. The test boilerplate and the member crud are probably the most useful

oh rad! thank you, I hadn't noticed that PR!

@aslilacaslilac changed the titleadd organization resourcefeat: add organization resourceNov 7, 2024
@aslilac
Copy link
MemberAuthor

I filled out the meat of this PR using your other branch as a reference. I'll work on the tests tomorrow–again basing off of your branch, but I want to try to use thestatecheck package that you mentioned on the issue.

@aslilacaslilac marked this pull request as ready for reviewNovember 8, 2024 22:57
@aslilac
Copy link
MemberAuthor

I've removedmembers from the org resource because I have some different ideas of how I want that to work. If it doesn't work out we can always go back to this, but in the meantime this is a solid bit that I'm definitely happy with.

ethanndickson reacted with thumbs up emoji

Copy link
Member

@EmyrkEmyrk left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM 👍

I need to learn some of these terraform provider libs...

Copy link
Member

@ethanndicksonethanndickson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

👍


var org codersdk.Organization
var err error
if data.ID.IsNull() {
Copy link
Member

@ethanndicksonethanndicksonNov 14, 2024•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Your import test supplies a UUID into the name field, butOrganization andOrganizationByName call the same endpoint, so I believe supporting imports by name will always allow you to import by ID? Hence why the import test is passing when it shouldn't. Setting the attributes at the bottom corrects the issue where the name is temporarily the UUID, so I don't think it's bug prone.

@aslilacaslilac merged commit1ef2a69 intomainNov 14, 2024
13 checks passed
@aslilacaslilac deleted the lilac/add-organization-resource branchNovember 14, 2024 20:21
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@EmyrkEmyrkEmyrk approved these changes

@ethanndicksonethanndicksonethanndickson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@aslilac@ethanndickson@Emyrk
[8]ページ先頭
©2009-2025 Movatter.jp