- Notifications
You must be signed in to change notification settings - Fork3
fix: skip validating unknown version names#123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This stack of pull requests is managed by Graphite.Learn more about stacking. Join@ethanndickson and the rest of your teammates on |
352de2d
toa533bc8
Compareif version.Name.IsNull() { | ||
continue | ||
} | ||
if _, ok := uniqueNames[version.Name.ValueString()]; ok { |
ethanndicksonOct 31, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
If two names were populated using Terraform variables, they'd beUnknown
andValueString
would return the empty string for both, which would then lead to a false duplicate in the map.
9321b39
intomainUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Same problem as seen in#115.
This fixes a problem where having multiple template version names manually set using Terraform variables would always return a duplicate name error, as Terraform would mark the attribute, although it is required and already written in the config, as Unknown before calling our custom validator. This unknown value is only ever passed to the validator, never
Create
orUpdate
.Knowing this, we see the same problem exists for all attributes we read in our custom validator. The only remaining one is
active
, where we check at least one version is marked as active. In this case, we also need to skip validatingactive
if any of the booleans are unknown.We previously didn't have any tests that explicitly used Terraform variables, so this PR adds one, in case the behaviour of these variable set attributes is changed in the future.