- Notifications
You must be signed in to change notification settings - Fork3
fix: skip validating unknown versions list#115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite.Learn more about stacking. Join@ethanndickson and the rest of your teammates on |
269046e
intomain 14 checks passed
Uh oh!
There was an error while loading.Please reload this page.
ethanndickson added a commit that referenced this pull requestOct 31, 2024
Same problem as seen in#115.This fixes a problem where having multiple template version namesmanually set using Terraform variables would always return a duplicatename error, as Terraform would mark the attribute, although it isrequired and already written in the config, as Unknown before callingour custom validator. This unknown value is only ever passed to thevalidator, never `Create` or `Update`.Knowing this, we see the same problem exists for all attributes we readin our custom validator. The only remaining one is `active`, where wecheck at least one version is marked as active. In this case, we alsoneed to skip validating `active` if any of the booleans are unknown.We previously didn't have any tests that explicitly used Terraformvariables, so this PR adds one, in case the behaviour of these variableset attributes is changed in the future.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
This fixes an error when setting the
versions
attribute of acoderd_template
using a variable, e.g:would return:
This error was caused by attempting to validate the versions list without checking if the config value is unknown. Normally, this value should never be unknown, as it's required, but it looks like Terraform does a configuration validationbefore variables are populated, as well as after.
To confirm this is the correct solution, we see that all the default validators perform the same null & unknown checks, e.g: