Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also orlearn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also.Learn more about diff comparisons here.
base repository:coder/terraform-provider-coderd
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base:main
Choose a base ref
Loading
...
head repository:coder/terraform-provider-coderd
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare:fix/oidc-user-roles-empty-list
Choose a head ref
Loading
Checking mergeability… Don’t worry, you can still create the pull request.
  • 4commits
  • 1file changed
  • 3contributors

Commits on Aug 14, 2025

  1. fix: add proper OIDC user role validation

    When creating OIDC users, the provider was calling UpdateUserRoleseven with empty roles due to the default schema value, causing theserver error "User Role Field is set in the OIDC configuration".OIDC users should get their roles exclusively from the OIDC provider'srole mapping, not from explicit API calls. This fix:- Errors if explicit roles are provided for OIDC users- Skips role assignment entirely for OIDC users- Provides clear error messaging about OIDC role behavior🤖 Generated with [Claude Code](https://claude.ai/code)Co-Authored-By: Claude <noreply@anthropic.com>
    @angrycub@claude
    angrycub andclaude committedAug 14, 2025
    Configuration menu
    Copy the full SHA
    d8d4d6fView commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2025

  1. fix: prevent config drift for OIDC users in Read function

    Update the Read function to not populate roles from server response for OIDC users.This prevents Terraform from detecting config drift when OIDC users have rolesassigned by the OIDC provider but an empty roles list in the Terraform config.Addresses review comment about config drift in PR#247.Co-authored-by: angrycub <464492+angrycub@users.noreply.github.com>
    @blink-so@angrycub
    blink-so[bot] andangrycub committedAug 15, 2025
    Configuration menu
    Copy the full SHA
    e7df6a1View commit details
    Browse the repository at this point in the history
  2. refactor: improve code style with consistent negative conditions

    Update OIDC user role handling to use cleaner Go style:- Use negative conditions (loginType != codersdk.LoginTypeOIDC) for better readability- Simplify comments to be more concise and inline- Maintain all existing validation logic and functionalityCo-authored-by: angrycub <464492+angrycub@users.noreply.github.com>
    @blink-so@angrycub
    blink-so[bot] andangrycub committedAug 15, 2025
    Configuration menu
    Copy the full SHA
    9ecc2e1View commit details
    Browse the repository at this point in the history
  3. style: run go fmt to fix formatting

    Fix formatting issues found by go fmt, specifically the closing braceplacement in the ImportState function.Co-authored-by: angrycub <464492+angrycub@users.noreply.github.com>
    @blink-so@angrycub
    blink-so[bot] andangrycub committedAug 15, 2025
    Configuration menu
    Copy the full SHA
    2e40dabView commit details
    Browse the repository at this point in the history
Loading

[8]ページ先頭

©2009-2025 Movatter.jp