- Notifications
You must be signed in to change notification settings - Fork22
feat: Add auth property to coder_agent_script#5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This enables explicit definition of auth type, so the agentdoesn't misinterpret the running environment.This also adds "username" and "name" properties to "coder_workspace"to allow for pretty resource naming inside a cloud.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
left one comment on naming. NB
| @@ -65,6 +65,8 @@ func New() *schema.Provider { | |||
| transition = "start" | |||
| } | |||
| rd.Set("transition", transition) | |||
| rd.Set("username", os.Getenv("CODER_WORKSPACE_USERNAME")) | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
thoughts onowner andCODER_WORKSPACE_OWNER instead? to me, username sounds like a property unique to the workspace.
This enables explicit definition of auth type, so the agentdoesn't misinterpret the running environment.This also adds "username" and "name" properties to "coder_workspace"to allow for pretty resource naming inside a cloud.
This enables explicit definition of auth type, so the agent
doesn't misinterpret the running environment.
This also adds "username" and "name" properties to "coder_workspace"
to allow for pretty resource naming inside a cloud.