- Notifications
You must be signed in to change notification settings - Fork24
feat: addenabled computed field tocoder_ai_task#451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation
1accf42 to90633dbCompareAs discussed, we want to enable a way for consumers to know if theirtemplate is being provisioned as a task or not. We know that`CODER_TASK_ID` is set by the provisioner, it is being provisioned asa task, and not as a usual workspace. We use this knowledge to seta computed field `enabled` to reflect this.fix: testsfix: maybe fix?does this fix it?
90633db to9b25602Compare
mafredri left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Probably fine, but I wonder if template building can be affected by this. At least when doing template build I imagine this value will always be false, and if including something is included conditionally, will that delay validation of certain things until workspace/task build?
Perhaps templates need a "build as task" mode to properly test writing them.
1211f28 intomainUh oh!
There was an error while loading.Please reload this page.
As discussed, we want to enable a way for consumers to know if their template is being provisioned as a task or not. We know that
CODER_TASK_IDis set by the provisioner, it is being provisioned as a task, and not as a usual workspace. We use this knowledge to set a computed fieldenabledto reflect this.