Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix: makeai_task.id change backwards compatible#447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
DanielleMaywood merged 3 commits intomainfromdanielle/tasks/id-fix
Oct 2, 2025

Conversation

DanielleMaywood
Copy link
Contributor

@DanielleMaywoodDanielleMaywood commentedOct 1, 2025•
edited
Loading

Update the create logic to warn instead of error when noCODER_TASK_ID is set so that we are backwards compatible.

@DanielleMaywoodDanielleMaywood marked this pull request as ready for reviewOctober 1, 2025 18:30
Co-authored-by: Cian Johnston <cian@coder.com>
Copy link
Member

@johnstcnjohnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Can we also add an integration test that validates backward compat?

@DanielleMaywood
Copy link
ContributorAuthor

Can we also add an integration test that validates backward compat?

Can do 👍

@DanielleMaywood
Copy link
ContributorAuthor

DanielleMaywood commentedOct 2, 2025•
edited
Loading

So the integration test is kinda messy since we have a chicken-and-the-egg problem ofcoder/coder not yet supporting the updated resource 😄

Copy link
Member

@johnstcnjohnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This is fine for now. Once we add support incoder/coder proper then we can update the test.

@DanielleMaywoodDanielleMaywood merged commiteb191d3 intomainOct 2, 2025
6 checks passed
@DanielleMaywoodDanielleMaywood deleted the danielle/tasks/id-fix branchOctober 2, 2025 11:37
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsOct 2, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@johnstcnjohnstcnjohnstcn approved these changes

Assignees

@DanielleMaywoodDanielleMaywood

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@DanielleMaywood@johnstcn
[8]ページ先頭
©2009-2025 Movatter.jp