- Notifications
You must be signed in to change notification settings - Fork23
ci: fix go version to that defined in go.mod#438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Changes fromall commits
aeb1c577de5dd66f452cd759a03ebfceb4c1547929File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -19,15 +19,18 @@ jobs: | ||
| name: Run Integration Tests | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Check out code into the Go module directory | ||
| uses: actions/checkout@v5 | ||
| - name: Check Go Versions | ||
| run: ./scripts/check_go_version.sh | ||
| - name: Set up Go | ||
| uses: actions/setup-go@v5 | ||
| with: | ||
| go-version: "1.24.2" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. Why do these need this to be in sync? IIRC Go will run as the version defined in See: Btw, There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. The see#437 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. Ah, gotcha, so they're preventing that behavior now. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. #439 stacked the original PR on top and it's green ✅ There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. Ignore my comment about 1.24.6 btw, originally thought this was a PR to coder/coder repo 😄 | ||
| id: go | ||
| - name: Get dependencies | ||
| run: | | ||
| go mod download | ||
| @@ -74,13 +77,16 @@ jobs: | ||
| - name: Checkout | ||
| uses: actions/checkout@v5 | ||
| - name: Check Go Versions | ||
| run: ./scripts/check_go_version.sh | ||
| - name: Unshallow | ||
| run: git fetch --prune --unshallow | ||
| - name: Set up Go | ||
| uses: actions/setup-go@v5 | ||
| with: | ||
| go-version:"1.24.2" | ||
| - name: Import GPG key | ||
| id: import_gpg | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| #!/usr/bin/env bash | ||
| set -euo pipefail | ||
| MOD_VERSION=$(go mod edit -json | jq -r .Go) | ||
| echo "go.mod version: $MOD_VERSION" | ||
| STATUS=0 | ||
| if [[ " $* " == *" --fix "* ]]; then | ||
| for wf in .github/workflows/*.{yml,yaml}; do | ||
| sed -i "s/go-version:.*/go-version: \"${MOD_VERSION}\"/g" "${wf}" | ||
| done | ||
| exit 0 | ||
| fi | ||
| for wf in .github/workflows/*.{yml,yaml}; do | ||
| WF_VERSIONS=$(yq -r '.jobs[].steps[] | select(.with["go-version"]) | .with["go-version"]' -o=tsv "$wf" | grep -v '^---$' || true) | ||
| if [[ -z "$WF_VERSIONS" ]]; then | ||
| continue | ||
| fi | ||
| UNIQUE_WF_VERSIONS=$(sort -u <<<"$WF_VERSIONS") | ||
| for ver in $UNIQUE_WF_VERSIONS; do | ||
| if [[ $ver != "$MOD_VERSION" ]]; then | ||
| STATUS=1 | ||
| echo "❌ $wf: go.mod=$MOD_VERSION but workflow uses $(tr '\n' ' ' <<<"$UNIQUE_WF_VERSIONS")" | ||
| continue | ||
| fi | ||
| done | ||
| done | ||
| if [[ $STATUS -eq 1 ]]; then | ||
| echo "Re-run this script with --fix to automatically update workflows to match go.mod" | ||
| fi | ||
| exit $STATUS |