Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat: add tooltip field to workspace app#435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
rafrdz merged 4 commits intomainfromrafrdz/tooltip-support
Sep 10, 2025
Merged

Conversation

rafrdz
Copy link

@rafrdzrafrdz commentedAug 29, 2025
edited
Loading

Summary

In this pull request we're adding an optionaltooltip field. Thetooltip field is a string field (with markdown support) that will be used to display tooltips on hover over app buttons in a workspace dashboard.

Tooltip screenshot

Screenshot 2025-08-29 at 4 11 56 PM

Tooltip video

tooltip-link.mov

Issue:coder/coder#18431
Related coder PR:coder/coder#19651

Changes

  • Addedtooltip to theapp schema with a max length of 2048 characters
  • Updatedapp documentation to include thetooltip field
  • Added an exampletooltip

Testing

  • Added tests for empty, valid, and max length (to test validation logic)

@matifali
Copy link
Member

I wonder if the markdown link in the tooltip is clickable. What happens when you move from the button to the tooltip? Does it disappear?

@rafrdz
Copy link
Author

I wonder if the markdown link in the tooltip is clickable. What happens when you move from the button to the tooltip? Does it disappear?

@matifali Updated the PR description with a short video showing what clicking a link in the tooltip looks like. Hopefully that helps!

matifali reacted with heart emoji

@matifali
Copy link
Member

@rafrdz This is great. Thank you.

rafrdz reacted with hooray emoji

@matifali
Copy link
Member

matifali commentedSep 7, 2025
edited
Loading

@rafrdz, one last thing to consider here is if someone used the latest provider with an older version of Coder, where this is not supported? Can we add a warning (or better, fail) in the provider to inform the user of the minimum required Coder version?

This warning/error should only happen if someone tries to usetooltip on an older Coder version.

If this looks like too much work, I am fine extracting that into a separate PR.

rafrdz reacted with eyes emoji

@rafrdz
Copy link
Author

@rafrdz, one last thing to consider here is if someone used the latest provider with an older version of Coder, where this is not supported? Can we add a warning (or better, fail) in the provider to inform the user of the minimum required Coder version?

This warning/error should only happen if someone tries to usetooltip on an older Coder version.

If this looks like too much work, I am fine extracting that into a separate PR.

@matifali Took a look and discussed this with others. Sounds like it'll be a bit of work so going to create an issue for this.

matifali reacted with thumbs up emoji

@rafrdzrafrdz merged commitbb2167e intomainSep 10, 2025
6 checks passed
@rafrdzrafrdz deleted the rafrdz/tooltip-support branchSeptember 10, 2025 14:55
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsSep 10, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@johnstcnjohnstcnjohnstcn approved these changes

@brettkolodnybrettkolodnybrettkolodny approved these changes

Assignees

@rafrdzrafrdz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@rafrdz@matifali@johnstcn@brettkolodny

[8]ページ先頭

©2009-2025 Movatter.jp