- Notifications
You must be signed in to change notification settings - Fork23
feat(coder-attach): add coder_external_agent resource#424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| func TestExternalAgent(t *testing.T) { | ||
| t.Parallel() | ||
| t.Run("OK", func(t *testing.T) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Should also have a test that links this resource to acoder_agent.
provider/external_agent.go Outdated
| "token": { | ||
| ForceNew: true, | ||
| Required: true, | ||
| Sensitive: true, | ||
| Description: "Set the environment variable `CODER_AGENT_TOKEN` with this token to authenticate an agent.", | ||
| Type: schema.TypeString, | ||
| }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I don't understand linking these based on the token value rather than just the ID value of the agent. It seems like we'd want to be able to configure the auth type on thecoder_agent and have that also apply here.
e04ea9c intomainUh oh!
There was an error while loading.Please reload this page.
This PR introduces a new Terraform resource
coder_external_agentthat allows users to define external agents for use in workspaces. It allows the coder UI and coder/coder to detect and act on external agent presence.This is part ofcoder/coder#19091