- Notifications
You must be signed in to change notification settings - Fork22
Fix coder_script agent_id reference typos#418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
+8 −8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Correct agent_id references from coder_agent.dev.agent_id to coder_agent.dev.idin both examples and documentation. The agent_id field should reference theagent resource id, not the agent_id field of the agent resource.Co-authored-by: matifali <10648092+matifali@users.noreply.github.com>
matifali approved these changesJun 27, 2025
Thanks for the quick review and approval! 🎉 |
6a6f740
intomain 6 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes incorrect
agent_id
references incoder_script
examples and documentation.Changes:
agent_id = coder_agent.dev.agent_id
toagent_id = coder_agent.dev.id
in 8 locationsexamples/resources/coder_script/resource.tf
anddocs/resources/script.md
Context:
The
agent_id
field should reference the agent resource'sid
attribute, not theagent_id
field of the agent resource itself. This was inconsistent in the examples where some resources correctly used.id
while others incorrectly used.agent_id
.Testing:
Verified all instances of the incorrect pattern have been fixed and no new issues were introduced.