Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore: add minimum TTL value for expiration.policy.ttl#406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

ssncferreira
Copy link
Contributor

@ssncferreirassncferreira commentedMay 26, 2025•
edited
Loading

Summary

This PR improves validation for theexpiration_policy.ttl field in the Terraform schema by allowing an explicit value of0 to disable expiration, while also enforcing a valid range of 3600 seconds (1 hour) to 31536000 seconds (1 year) for all other values. This ensures that prebuild TTLs are not configured with values that are too short, which could lead to premature expiration and unnecessary prebuild churn.

Changes

  • Replaced validation.IntBetween with a custom validation function.
  • TTL is now allowed to be:
    • 0 disables expiration
    • Between3600 and31536000 to enforce TTL values between 1 hour and 1 year.

No functional changes beyond input validation.

Related to:#404

@ssncferreirassncferreira marked this pull request as ready for reviewMay 26, 2025 18:43
Copy link
Member

@mafredrimafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Except for the disable gotcha, LGTM 👍🏻

Copy link
Member

@mtojekmtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

👍

@ssncferreirassncferreira merged commit442ff2a intomainMay 27, 2025
6 checks passed
@ssncferreirassncferreira deleted the ssncferreira/chore-prebuild-ttl-min-validation branchMay 27, 2025 10:04
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsMay 27, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@mafredrimafredrimafredri approved these changes

@johnstcnjohnstcnjohnstcn approved these changes

@mtojekmtojekmtojek approved these changes

@SasSwartSasSwartAwaiting requested review from SasSwart

@evgeniy-scherbinaevgeniy-scherbinaAwaiting requested review from evgeniy-scherbina

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@ssncferreira@mafredri@johnstcn@mtojek
[8]ページ先頭
©2009-2025 Movatter.jp