- Notifications
You must be signed in to change notification settings - Fork22
chore: add minimum TTL value for expiration.policy.ttl#406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
ssncferreira merged 2 commits intomainfromssncferreira/chore-prebuild-ttl-min-validationMay 27, 2025
Merged
chore: add minimum TTL value for expiration.policy.ttl#406
ssncferreira merged 2 commits intomainfromssncferreira/chore-prebuild-ttl-min-validationMay 27, 2025
+58 −4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
mafredri approved these changesMay 27, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Except for the disable gotcha, LGTM 👍🏻
Uh oh!
There was an error while loading.Please reload this page.
mtojek approved these changesMay 27, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
👍
johnstcn approved these changesMay 27, 2025
mafredri approved these changesMay 27, 2025
442ff2a intomain 6 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Labels
None yet
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Summary
This PR improves validation for the
expiration_policy.ttlfield in the Terraform schema by allowing an explicit value of0to disable expiration, while also enforcing a valid range of 3600 seconds (1 hour) to 31536000 seconds (1 year) for all other values. This ensures that prebuild TTLs are not configured with values that are too short, which could lead to premature expiration and unnecessary prebuild churn.Changes
0disables expiration3600and31536000to enforce TTL values between 1 hour and 1 year.No functional changes beyond input validation.
Related to:#404