Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat: enforce monotonicity in terraform provider#392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Emyrk merged 3 commits intomainfromstevenmasley/monotonic
May 8, 2025

Conversation

Emyrk
Copy link
Member

@EmyrkEmyrk commentedMay 6, 2025
edited
Loading

Previous value must come from env var. This change has to be made incoder/coder to take advantage of this.

CODER_PARAMETER_PREVIOUS_<hash>

Unfortunately reading fromtfstate requires the block to be aresource block. This is because adata block only has access to theRead context.

https://github.com/hashicorp/terraform-plugin-sdk/blob/main/helper/schema/resource.go#L287-L354
Read

// The *ResourceData parameter contains the state data for this managed
// resource instance or data resource instance.

Update

// TheResourceData parameter contains the plan and state data for this
// managed resource instance. The available data in the Get
methods is the
// the proposed state, which is the merged data of the prior state,
// practitioner configuration, and any CustomizeDiff field logic. The
// available data for the GetChange* and HasChange* methods is the prior
// state and proposed state.

coder/coder PR in progresscoder/coder#17696

@EmyrkEmyrk requested a review fromspikecurtisMay 6, 2025 21:30
Base automatically changed fromstevenmasley/value_validate tomainMay 7, 2025 13:01
Emyrk added2 commitsMay 7, 2025 09:30
Previous value must come from env var. To read tfstate requireschanging param from a `data` block to a `resource` block
@EmyrkEmyrkforce-pushed thestevenmasley/monotonic branch frome011f73 to6f94a4bCompareMay 7, 2025 14:30
@EmyrkEmyrk requested review fromjohnstcn andSasSwart and removed request forjohnstcnMay 7, 2025 14:30
| NumDefDecBad | number | 4 | | 5 | | decreasing | | | | lower |
| NumDefDecEq | number | 5 | | 5 | | decreasing | | 5 | true | |
| NumDefIncEq | number | 5 | | 5 | | increasing | | 5 | true | |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

test case for previous not a number?

Emyrk reacted with thumbs up emoji
@EmyrkEmyrk merged commit8692a56 intomainMay 8, 2025
6 checks passed
@EmyrkEmyrk deleted the stevenmasley/monotonic branchMay 8, 2025 14:36
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsMay 8, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@spikecurtisspikecurtisspikecurtis approved these changes

@SasSwartSasSwartAwaiting requested review from SasSwart

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@Emyrk@spikecurtis

[8]ページ先頭

©2009-2025 Movatter.jp