- Notifications
You must be signed in to change notification settings - Fork22
test: add more validation test cases#388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Some of these cases you would expect it to be an error, but thevalidation passes
Emyrk commentedApr 30, 2025
| @@ -18,6 +20,8 @@ | |||
| | NumDefOpts | number | | 5 | 1,3,5,7 | 2-6 | | 5 | true | | | |||
| | NumDefNotOpts | number | | 5 | 1,3,7,9 | 2-6 | | | | valid option | | |||
| | NumDefInvOpt | number | | 5 | 1,3,5,7 | 6-10 | | | | 6 < 5 < 10 | | |||
| | NumDefNotNum | number | | a | | | | | | a number | | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
So you can pass in "a" for a "number" param... interesting.
You can see it for yourself:
data"coder_parameter""region" {name="region"type="number"order=1}
$ CODER_PARAMETER_c697d2981bf416569a16cfbcdec1542b5398f3cc77d2b905819aa99c46ecf6f6=nan terraform apply&& terraform show# data.coder_parameter.region:data"coder_parameter""region" { description ="Which region would you like to deploy to?" ephemeral =false form_type ="input" id ="2aec6abf-883a-4618-98c6-6e262e2bfd9b" mutable =false name ="region" optional =false order = 1 styling = jsonencode({})type ="number" value ="nan"}
aslilac approved these changesApr 30, 2025
4e7da25 intomain 6 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some of these cases you would expect it to be an error, but the validation passes