- Notifications
You must be signed in to change notification settings - Fork23
feat: parameter validation refactored to single function#381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
+440 −204
Merged
Changes fromall commits
Commits
Show all changes
24 commits Select commitHold shift + click to select a range
875b316 validate input vales
Emyrk9bb9a1f begin adding invalid unit tests
Emyrk6ee8b80 add more validation tests
Emyrk2cb01cc add better error message
Emyrk5e19e2a revert test removal'
Emyrkb6787b0 WIP
Emyrkaaf1a17 chore: refactor validation while still keeping it mostly the same
Emyrk7cf79d8 fixup test cases
Emyrkbb16d1e fixup test cases
Emyrk506f1c9 add nan cases
Emyrka0ccb6f merge cases
Emyrkfe4b4d7 remove comment
Emyrk0ad4eb6 chore: distinguish unset vs set default and values
Emyrk62f36ea add 2 validation modes
Emyrk247df4e add commented block
Emyrkdd7af3b move constant
Emyrkfbd613e remove duped validation
Emyrk5ef834e Test fixes
Emyrk3a36fbb PR fixes
Emyrk22f12cb rename Valid -> ValidateInput
Emyrkf7b9338 Merge remote-tracking branch 'origin/main' into stevenmasley/value_va…
Emyrk0fd96ee remove validation modes
Emyrk9433b31 chore: use default path in error if sourced from default
Emyrk79d3bf7 chore: always use the path argument, not default path
EmyrkFile filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
There are no files selected for viewing
Oops, something went wrong.
Uh oh!
There was an error while loading.Please reload this page.
Oops, something went wrong.
Uh oh!
There was an error while loading.Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.