- Notifications
You must be signed in to change notification settings - Fork24
feat: reuse agent tokens when a prebuilt agent reinitializes#374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation
johnstcn left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I think this isdefinitely worth an integration test :-)
dannykopping left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I don't think this PR is ready for review yet, is it?
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
| // and after the workspace was claimed by a user. | ||
| // | ||
| // agentID is unused for now, but will be used as soon as we support multiple agents. | ||
| funcRunningAgentTokenEnvironmentVariable(agentIDstring)string { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
How will the ID be injected? How will we maintain a persistent identity acrossterraform apply runs?
5648efb intomainUh oh!
There was an error while loading.Please reload this page.
This PRcloses#364