Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: reuse agent tokens when a prebuilt agent reinitializes#374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
SasSwart merged 13 commits intomainfromjjs/364
May 2, 2025

Conversation

SasSwart
Copy link
Contributor

This PRcloses#364

Copy link
Member

@johnstcnjohnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I think this isdefinitely worth an integration test :-)

Base automatically changed fromjjs/363 tomainApril 7, 2025 06:20
Copy link
Contributor

@dannykoppingdannykopping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I don't think this PR is ready for review yet, is it?

@SasSwartSasSwart marked this pull request as draftApril 10, 2025 10:09
// and after the workspace was claimed by a user.
//
// agentID is unused for now, but will be used as soon as we support multiple agents.
funcRunningAgentTokenEnvironmentVariable(agentIDstring)string {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

How will the ID be injected? How will we maintain a persistent identity acrossterraform apply runs?

@dannykoppingdannykopping self-requested a reviewApril 17, 2025 11:34
@SasSwartSasSwart marked this pull request as ready for reviewApril 23, 2025 12:06
@SasSwartSasSwart merged commit5648efb intomainMay 2, 2025
6 checks passed
@SasSwartSasSwart deleted the jjs/364 branchMay 2, 2025 06:57
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsMay 2, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@johnstcnjohnstcnjohnstcn left review comments

@dannykoppingdannykoppingAwaiting requested review from dannykopping

Assignees

@SasSwartSasSwart

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ensure the workspace agent can reuse its existing token when required
4 participants
@SasSwart@dannykopping@johnstcn@Emyrk
[8]ページ先頭
©2009-2025 Movatter.jp