- Notifications
You must be signed in to change notification settings - Fork24
chore: test auto prerelease#347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This configures goreleaser to automate prereleases when we push a tag that contains `pre` or `rc`
johnstcn left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
🤞
.goreleaser.yml Outdated
| prerelease:auto | ||
| make_latest:"{{ not .Prerelease }}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
As perhttps://goreleaser.com/customization/templates/
make_latest:"{{ not .Prerelease }}"
is wrong and
"{{ .Prerelease }}"will evaluate topre
It is not a boolean, so my change will not work.
QQ: Can I match a template check for
"{{ .Prerelease == 'pre' }}"I am assuming templating works the same as they do in Helm charts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
It looks like templates aren't supported inmake_latest yet.
There's a PR to support this:goreleaser/goreleaser#5418 that got released in v2.6.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I think it's merged and available as per v2.6.0
goreleaser/goreleaser#5420
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
{{ eq (.Prerelease | len) 0 }}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
make_latest: {{ not .Prerelease }} should also returnmake_latest: true when.Prerelease is empty.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Reverting the change.
johnstcn left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
{{ not .Prerelease }} should also work as you suggested:https://go.dev/play/p/aDU6YypI2KT
249863d intomainUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
This configures goreleaser to automate prereleases when we push a tag that contains
preorrcRef:https://goreleaser.com/customization/release/#github