- Notifications
You must be signed in to change notification settings - Fork24
feat: add a workspace preset datasource#332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
SasSwart left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Self review:
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
dannykopping left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Minor comment about the idiomatic approach to validation but otherwise LGTM
Feel free to ignore the nits.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
d7d2b70 intomainUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
This pull request adds
data "coder_workspace_preset" {}Basic validation is done when the data source is read, but cross validation against
coder_parameterdata sources happens in the provisioner in coder/coder.Once merged into main, we'll need to backport to
v1.0.5and bump the dependency incoder/coder, because we rely on types in this provider in the coder provisioner.