Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat: add a workspace preset datasource#332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
SasSwart merged 10 commits intomainfromjjs/presets
Feb 4, 2025
Merged

feat: add a workspace preset datasource#332

SasSwart merged 10 commits intomainfromjjs/presets
Feb 4, 2025

Conversation

@SasSwart
Copy link
Contributor

@SasSwartSasSwart commentedJan 28, 2025
edited
Loading

This pull request addsdata "coder_workspace_preset" {}

Basic validation is done when the data source is read, but cross validation againstcoder_parameter data sources happens in the provisioner in coder/coder.

Once merged into main, we'll need to backport tov1.0.5 and bump the dependency incoder/coder, because we rely on types in this provider in the coder provisioner.

Copy link
ContributorAuthor

@SasSwartSasSwart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Self review:

Copy link
Contributor

@dannykoppingdannykopping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Minor comment about the idiomatic approach to validation but otherwise LGTM
Feel free to ignore the nits.

@SasSwartSasSwart merged commitd7d2b70 intomainFeb 4, 2025
8 checks passed
@SasSwartSasSwart deleted the jjs/presets branchFebruary 4, 2025 08:26
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsFeb 4, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@dannykoppingdannykoppingdannykopping approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@SasSwart@dannykopping

[8]ページ先頭

©2009-2025 Movatter.jp