Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix: update to terraform-plugin-sdk v2.34.0#290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
spikecurtis merged 1 commit intomainfromspike/sdk-2.34.0
Sep 24, 2024

Conversation

spikecurtis
Copy link
Contributor

@spikecurtisspikecurtis commentedSep 24, 2024
edited
Loading

Speculative fix in relation tocoder/coder#14726

There have been several issues fixed in the plugin-sdk and its dependencies about go routines and the RPC protocol. Since ourcoder plugin is itself very, very simple in design (it generally just reads data from environment variables for data sources, and just does validation on resources), it's hard to imagine a hang in our provider schema code (not impossible tho). The error reports we've seen all show the Coder provider as the one that is involved intext file busy, so it seems likely that it's something unique about thecoder/coder provider.

hashicorp/kubernetes is used by both customers who reported thetext file busy error, and it is on SDK version 2.29+ and we were back on 2.20 before this PR.

@spikecurtisGraphite App
Copy link
ContributorAuthor

This stack of pull requests is managed by Graphite.Learn more about stacking.

Join@spikecurtis and the rest of your teammates onGraphiteGraphite

@spikecurtisspikecurtis marked this pull request as ready for reviewSeptember 24, 2024 11:44
Copy link
Member

@johnstcnjohnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

v2.24.1 fixes some goroutine leaks, maybe related?
In any case, 👍

@spikecurtisGraphite App
Copy link
ContributorAuthor

spikecurtis commentedSep 24, 2024
edited
Loading

Merge activity

@spikecurtisspikecurtis merged commit1e84894 intomainSep 24, 2024
9 checks passed
@spikecurtisspikecurtis deleted the spike/sdk-2.34.0 branchSeptember 24, 2024 11:56
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsSep 24, 2024
@matifali
Copy link
Member

@spikecurtis we can patch the 1.0 after cherry picking this change intorelease/1.0 branch.

Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@johnstcnjohnstcnjohnstcn approved these changes

@mtojekmtojekAwaiting requested review from mtojek

Assignees

@spikecurtisspikecurtis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@spikecurtis@matifali@johnstcn

[8]ページ先頭

©2009-2025 Movatter.jp