- Notifications
You must be signed in to change notification settings - Fork22
fix: update to terraform-plugin-sdk v2.34.0#290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This stack of pull requests is managed by Graphite.Learn more about stacking. Join@spikecurtis and the rest of your teammates on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
v2.24.1 fixes some goroutine leaks, maybe related?
In any case, 👍
spikecurtis commentedSep 24, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Merge activity
|
1e84894
intomainUh oh!
There was an error while loading.Please reload this page.
@spikecurtis we can patch the 1.0 after cherry picking this change into |
Uh oh!
There was an error while loading.Please reload this page.
Speculative fix in relation tocoder/coder#14726
There have been several issues fixed in the plugin-sdk and its dependencies about go routines and the RPC protocol. Since our
coder
plugin is itself very, very simple in design (it generally just reads data from environment variables for data sources, and just does validation on resources), it's hard to imagine a hang in our provider schema code (not impossible tho). The error reports we've seen all show the Coder provider as the one that is involved intext file busy
, so it seems likely that it's something unique about thecoder/coder
provider.hashicorp/kubernetes
is used by both customers who reported thetext file busy
error, and it is on SDK version 2.29+ and we were back on 2.20 before this PR.