Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix: validate agent & resource metadata keys during plan#277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

ethanndickson
Copy link
Member

@ethanndicksonethanndickson commentedSep 5, 2024•
edited
Loading

Closescoder/coder#14387.
Closescoder/coder#14569.

Previously, the configuration had to be applied in order for the provider to complain about duplicate keys - now just a plan will suffice.

@ethanndicksonGraphite App
Copy link
MemberAuthor

This stack of pull requests is managed by Graphite.Learn more about stacking.

Join@ethanndickson and the rest of your teammates onGraphiteGraphite

@ethanndicksonethanndicksonforce-pushed the09-05-fix_validate_agent_resource_metadata_keys_during_plan branch from6e8c7db tob005008CompareSeptember 5, 2024 13:30
@ethanndicksonethanndickson marked this pull request as ready for reviewSeptember 5, 2024 13:30
@ethanndicksonethanndicksonforce-pushed the09-05-fix_validate_agent_resource_metadata_keys_during_plan branch fromb005008 tofdb3846CompareSeptember 5, 2024 14:58
@ethanndicksonethanndicksonforce-pushed the09-05-fix_validate_agent_resource_metadata_keys_during_plan branch fromfdb3846 tofd94956CompareSeptember 5, 2024 15:26
@ethanndicksonethanndickson merged commitf69a14d intomainSep 5, 2024
9 checks passed
@ethanndicksonethanndickson deleted the 09-05-fix_validate_agent_resource_metadata_keys_during_plan branchSeptember 5, 2024 15:28
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsSep 5, 2024
@matifali
Copy link
Member

Do we want to port this torelease/1.0 and do a patch?

@ethanndickson
Copy link
MemberAuthor

ethanndickson commentedSep 6, 2024•
edited
Loading

Yeah, potentially. What are the breaking changes on main not included in any release? I'm not familiar

@matifali
Copy link
Member

We removed a couple of deprecated resources and attributes.

Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@johnstcnjohnstcnjohnstcn approved these changes

Assignees

@ethanndicksonethanndickson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Metadata dup key yields in internal error Conflicting terraformmetadata keys results inerror: internal provisionerserver error with no details
3 participants
@ethanndickson@matifali@johnstcn
[8]ページ先頭
©2009-2025 Movatter.jp